Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move phylocanvas to script entry point #19193

Merged
merged 1 commit into from
Nov 25, 2024
Merged

Move phylocanvas to script entry point #19193

merged 1 commit into from
Nov 25, 2024
+34 −142

Conversation

guerler
Copy link
Contributor

@guerler guerler commented Nov 24, 2024 •
edited
Loading

Migrates phylocanvas visualization to npm and script entry point.

image

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@guerler guerler marked this pull request as ready for review November 24, 2024 08:19
@github-actions github-actions bot added this to the 25.0 milestone Nov 24, 2024
@bgruening
Copy link
Member

Very cool!

@guerler guerler merged commit 7a68911 into galaxyproject:dev Nov 25, 2024
56 checks passed
@guerler guerler deleted the phylocanvas branch November 25, 2024 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bgruening bgruening bgruening approved these changes

Assignees
No one assigned
Labels
area/UI-UX area/visualizations kind/enhancement
Projects
None yet
Milestone
25.0
Development

Successfully merging this pull request may close these issues.
2 participants
@guerler @bgruening